-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LINK-1687 | Show signup edit page for registration user accesses #99
Conversation
dc6a507
to
7712a04
Compare
e2d8b17
to
ce1c5dc
Compare
Codecov Report
@@ Coverage Diff @@
## feature/LINK-1648_3-signups-page #99 +/- ##
====================================================================
+ Coverage 99.39% 99.40% +0.01%
====================================================================
Files 178 178
Lines 3306 3372 +66
Branches 525 547 +22
====================================================================
+ Hits 3286 3352 +66
Misses 20 20
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
7712a04
to
b5f5216
Compare
ce1c5dc
to
7928def
Compare
1a5e542
to
aa14520
Compare
7928def
to
6047032
Compare
08fed45
to
3a2dc8b
Compare
01c96c7
to
0f56f56
Compare
3a2dc8b
to
cee88ba
Compare
0f56f56
to
2798102
Compare
- Name fields works as a link to signup or signup group page in the signups table. Add return path to url params when clicking link - In edit signup page show back button if return path is added to url params. Move back to signups page by clicking back button
2798102
to
2181c93
Compare
The checkbox "I agree to share my information with the organizer..." can be checked and the "Continue to registration" button can be clicked even if the form is otherwise in read-only state. Should those rather be disabled if the user is not able to edit the form? |
- Registration user access user can view the signup or signup group but is not allowed to update it. Show form fields as read-only for those users
2181c93
to
77c5959
Compare
Yes, they should be disabled. I actually noticed this issued in our sprint demo but forgot to fix. Thanks for pointing it. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add link to signup or signup group to signups table
Show edit signups or signup group page to registration user access user in read-only mode. Only signup creator can update it.
Closes
LINK-1687
Screenshots