Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1687 | Show signup edit page for registration user accesses #99

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Nov 7, 2023

Description

Add link to signup or signup group to signups table
Show edit signups or signup group page to registration user access user in read-only mode. Only signup creator can update it.

Closes

LINK-1687

Screenshots

Screenshot 2023-11-07 at 16 24 35 Screenshot 2023-11-07 at 16 25 14

@jorilindell jorilindell requested review from harriris-vincit and a team November 7, 2023 14:28
@jorilindell jorilindell force-pushed the feature/LINK-1648_3-signups-page branch from dc6a507 to 7712a04 Compare November 13, 2023 11:34
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from e2d8b17 to ce1c5dc Compare November 13, 2023 11:42
@codecov-commenter
Copy link

Codecov Report

Merging #99 (ce1c5dc) into feature/LINK-1648_3-signups-page (7712a04) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                         Coverage Diff                          @@
##           feature/LINK-1648_3-signups-page      #99      +/-   ##
====================================================================
+ Coverage                             99.39%   99.40%   +0.01%     
====================================================================
  Files                                   178      178              
  Lines                                  3306     3372      +66     
  Branches                                525      547      +22     
====================================================================
+ Hits                                   3286     3352      +66     
  Misses                                   20       20              
Files Coverage Δ
...omain/attendanceList/attendeeList/AttendeeList.tsx 100.00% <ø> (ø)
src/domain/signup/utils.ts 100.00% <100.00%> (ø)
...in/signupGroup/editButtonPanel/EditButtonPanel.tsx 100.00% <100.00%> (ø)
...in/signupGroup/signupGroupForm/SignupGroupForm.tsx 100.00% <100.00%> (ø)
...in/signupGroup/signupGroupForm/signups/Signups.tsx 100.00% <ø> (ø)
...nupGroup/signupGroupForm/signups/signup/Signup.tsx 100.00% <100.00%> (ø)
src/domain/signupGroup/testUtils.ts 97.87% <100.00%> (+0.81%) ⬆️
src/domain/singups/signupsTable/SignupsTable.tsx 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jorilindell jorilindell force-pushed the feature/LINK-1648_3-signups-page branch from 7712a04 to b5f5216 Compare November 13, 2023 21:22
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from ce1c5dc to 7928def Compare November 13, 2023 21:24
@jorilindell jorilindell force-pushed the feature/LINK-1648_3-signups-page branch 2 times, most recently from 1a5e542 to aa14520 Compare November 17, 2023 11:54
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from 7928def to 6047032 Compare November 17, 2023 12:02
@jorilindell jorilindell force-pushed the feature/LINK-1648_3-signups-page branch 2 times, most recently from 08fed45 to 3a2dc8b Compare November 17, 2023 13:05
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch 3 times, most recently from 01c96c7 to 0f56f56 Compare November 17, 2023 13:52
@jorilindell jorilindell force-pushed the feature/LINK-1648_3-signups-page branch from 3a2dc8b to cee88ba Compare November 20, 2023 10:20
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from 0f56f56 to 2798102 Compare November 20, 2023 10:21
Base automatically changed from feature/LINK-1648_3-signups-page to feature/LINK-1648_2-attendance-list-page-buttons November 20, 2023 14:43
Base automatically changed from feature/LINK-1648_2-attendance-list-page-buttons to feature/LINK-1648_1-menu-dropdown-component November 20, 2023 14:43
Base automatically changed from feature/LINK-1648_1-menu-dropdown-component to main November 20, 2023 14:44
- Name fields works as a link to signup or signup group page in the signups table. Add return path to url params when clicking link
- In edit signup page show back button if return path is added to url params. Move back to signups page by clicking back button
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from 2798102 to 2181c93 Compare November 20, 2023 14:47
@harriris-vincit
Copy link

The checkbox "I agree to share my information with the organizer..." can be checked and the "Continue to registration" button can be clicked even if the form is otherwise in read-only state. Should those rather be disabled if the user is not able to edit the form?

- Registration user access user can view the signup or signup group but is not allowed to update it. Show form fields as read-only for those users
@jorilindell jorilindell force-pushed the feature/LINK-1687-view-signup-details branch from 2181c93 to 77c5959 Compare November 20, 2023 15:00
@jorilindell
Copy link
Contributor Author

The checkbox "I agree to share my information with the organizer..." can be checked and the "Continue to registration" button can be clicked even if the form is otherwise in read-only state. Should those rather be disabled if the user is not able to edit the form?

Yes, they should be disabled. I actually noticed this issued in our sprint demo but forgot to fix. Thanks for pointing it. Fixed now.

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorilindell jorilindell merged commit ae09d37 into main Nov 20, 2023
2 checks passed
@jorilindell jorilindell deleted the feature/LINK-1687-view-signup-details branch November 20, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants