Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HP-2277 Update email change notification #323

Merged
merged 2 commits into from
Mar 12, 2024
Merged

HP-2277 Update email change notification #323

merged 2 commits into from
Mar 12, 2024

Conversation

Riippi
Copy link
Contributor

@Riippi Riippi commented Mar 11, 2024

  • Show both notifications (success & verify) when changing suomifi or helsinki account email.
  • Change the type of verify email to "alert"
  • Increased version number to keep track

https://helsinkisolutionoffice.atlassian.net/browse/HP-2277

@Riippi Riippi requested a review from a team March 11, 2024 15:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-UI branch is deployed to platta: https://helsinki-profile-pr323-ui.dev.hel.ninja 🚀🚀🚀

mikkojamG
mikkojamG approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mikkojamG mikkojamG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Riippi Riippi merged commit 11929ca into main Mar 12, 2024
20 checks passed
@Riippi Riippi deleted the HP-2277-email-change-notifications branch March 12, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkojamG mikkojamG mikkojamG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Riippi @terovirtanen @mikkojamG