Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OM-807 | Apply confirmation modal fixes #69

Merged
merged 4 commits into from
May 20, 2020
Merged

OM-807 | Apply confirmation modal fixes #69

merged 4 commits into from
May 20, 2020

Conversation

Jokinen
Copy link
Contributor

@Jokinen Jokinen commented May 19, 2020

Annina asked for

  • the close icon to be aligned with the title
  • there to be more margin between the buttons and the content

I also applied these changes which someone will likely request later

  • Added a label for the close button for screen readers
  • Reordered buttons on mobile so that primary button is first

Screenshot 2020-05-19 at 14 39 56

Screenshot 2020-05-19 at 14 40 19

@Jokinen Jokinen merged commit 92c42a1 into develop May 20, 2020
@Jokinen Jokinen deleted the fix/om-807 branch May 20, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuovinensanttu tuovinensanttu tuovinensanttu approved these changes

@badrange badrange Awaiting requested review from badrange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jokinen @tuovinensanttu