Skip to content

Commit

Permalink
fix: preview reservation unit link disabled
Browse files Browse the repository at this point in the history
refs: TILA-3429
  • Loading branch information
joonatank committed Jun 20, 2024
1 parent 0b984ed commit 620709a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion apps/admin-ui/.env.example
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
NEXT_PUBLIC_BASE_URL=/kasittely
TILAVARAUS_API_URL=http://localhost:8000
TUNNISTAMO_URL=https://tunnistamo.test.hel.ninja
RESERVATION_UNIT_PREVIEW_URL_PREFIX="/"
RESERVATION_UNIT_PREVIEW_URL_PREFIX="http://localhost:3000/reservation-unit"
11 changes: 7 additions & 4 deletions apps/admin-ui/src/spa/ReservationUnit/edit/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1565,7 +1565,7 @@ function OpeningHoursSection({

const previewUrl = `${previewUrlPrefix}/${reservationUnit?.pk}?ru=${reservationUnit?.uuid}#calendar`;
const previewDisabled =
previewUrlPrefix !== "" || !reservationUnit?.pk || !reservationUnit?.uuid;
previewUrlPrefix === "" || !reservationUnit?.pk || !reservationUnit?.uuid;

// TODO refactor this to inner wrapper (so we don't have a ternary in the middle)
return (
Expand Down Expand Up @@ -2095,8 +2095,9 @@ function ReservationUnitEditor({
const previewDisabled =
isSaving ||
!reservationUnit?.pk ||
!reservationUnit?.uuid ||
previewUrlPrefix !== "";
!reservationUnit.uuid ||
previewUrlPrefix === "";

const draftEnabled = hasChanges || !watch("isDraft");
const publishEnabled = hasChanges || watch("isDraft");
const archiveEnabled = watch("pk") !== 0 && !watch("isArchived");
Expand Down Expand Up @@ -2288,6 +2289,8 @@ function EditorWrapper({ previewUrlPrefix }: { previewUrlPrefix: string }) {
];
const backLink = reservationUnitPk == null ? `/unit/${unitPk}` : undefined;

const cleanPreviewUrlPrefix = previewUrlPrefix.replace(/\/$/, "");

return (
<Wrapper>
<BreadcrumbWrapper route={route} backLink={backLink} />
Expand All @@ -2296,7 +2299,7 @@ function EditorWrapper({ previewUrlPrefix }: { previewUrlPrefix: string }) {
form={form}
unitPk={unitPk}
refetch={refetch}
previewUrlPrefix={previewUrlPrefix}
previewUrlPrefix={cleanPreviewUrlPrefix}
/>
</Wrapper>
);
Expand Down

0 comments on commit 620709a

Please sign in to comment.