Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update gql-types and re-enable reservation unit filter #1269

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: update gql-types and re-enable reservation unit filter #1269

merged 1 commit into from
Jun 27, 2024

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented Jun 27, 2024 •
edited
Loading

🛠️ Changelog

🧪 Test plan

  • Have a round which has rejected occcurrences and go check it, the filters should now include the reservation unit filter
  • Also: the unit filter now works with more than one choice too

🎫 Tickets

  • TILA-####

@vincit-matu vincit-matu force-pushed the add-back-reservation-unit-filter branch from 4427329 to 46d8621 Compare June 27, 2024 07:37
joonatank
joonatank approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vincit-matu vincit-matu merged commit 1d208c2 into main Jun 27, 2024
6 checks passed
@vincit-matu vincit-matu deleted the add-back-reservation-unit-filter branch June 27, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonatank joonatank joonatank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincit-matu @joonatank