Turku theme fixes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juhakujala
commented
Jun 17, 2019
•
juhakujala
commented
- Update styles and style variables
- Change turku logo files to correct ones
- Use turku primary color on the default-image.svg
- Add new turku specific translation strings
- Remove unecessary images
frwickst
suggested changes
Jun 17, 2019
| @@ -3,3 +3,6 @@ | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/variables"; | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/bootstrap"; | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/kerrokantasi"; | |||
|
|
|||
| @import "turku/navigation"; | |||
There was a problem hiding this comment.
Does this work even if the file is called _navigation.scss?
| @@ -3,3 +3,6 @@ | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/variables"; | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/bootstrap"; | |||
| @import "~kerrokantasi-ui/assets/sass/kerrokantasi/kerrokantasi"; | |||
|
|
|||
| @import "turku/navigation"; | |||
| @import "turku/labels"; | |||
There was a problem hiding this comment.
Does this work even if the file is called _labels.scss?
They do work. It's a convention that is also used in the kerrokantasi-ui repository now. The |
frwickst
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.