Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(develop) Make department contact field required in 'article' and 'how-to' pages; display optional DIG-4158 #3415

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

subaha-cob
Copy link
Contributor

@subaha-cob subaha-cob commented Apr 11, 2024

@davidrkupton davidrkupton changed the title DIG-4158 (develop) Make department contact field required in 'article' and 'how-to' pages; display optional DIG-4158 Apr 11, 2024
Copy link
Contributor

@davidrkupton davidrkupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@subaha-cob subaha-cob merged commit 276a33f into develop Apr 11, 2024
1 check passed
@@ -83,7 +83,7 @@

<div id="mobile-sidebar" class="column g--12">
<ul class="sb">
{% if content.field_contact["#items"] %}
{% if content.field_contact["#items"] and content.field_hide_contact_form['#items'].value == 0 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to ...value != 1

<div>Still have questions? Contact:</div>
{{ content.field_contact }}
</li>
{% if content.field_contact["#items"] and content.field_hide_contact_form['#items'].value == 0 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to ...value != 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants