Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1330/fixing forgot password redirect #1334

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

YazeedLoonat
Copy link
Collaborator

Description

After doing a password reset the public user was being redirected to the /applications route
This changed it, so that like after confirmation, the user is sent to their account dashboard route

How Can This Be Tested/Reviewed?

Create a user (or use an already existing user)
go to sign in as that user, but instead of signing in opt for the forgot password flow
go through the forgot password flow, and after resetting the password successfully you should be redirected to the account/dashboard route

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit c541df2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/62a7662f8928b9000718afea
😎 Deploy Preview https://deploy-preview-1334--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit c541df2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/62a7662f8ababa0008dff80d
😎 Deploy Preview https://deploy-preview-1334--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for detroit-storybook-dev ready!

Name Link
🔨 Latest commit c541df2
🔍 Latest deploy log https://app.netlify.com/sites/detroit-storybook-dev/deploys/62a7662ff1cb960008eb4a6e
😎 Deploy Preview https://deploy-preview-1334--detroit-storybook-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could we make this change in core as well?

@seanmalbert seanmalbert merged commit e2cefe2 into dev Jun 15, 2022
@seanmalbert seanmalbert deleted the 1330/reset-password-redirect-fix branch June 15, 2022 14:41
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After resetting password, public user's are redirected to applications page
3 participants