quickfix: cross-browser image sizing #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinBuyck
changed the title
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ludtkemorgan
approved these changes
Sep 14, 2022
| @@ -67,18 +67,6 @@ export const Overlay = (props: OverlayProps) => { | |||
| } | |||
| }, [elForPortal, overlayRoot]) | |||
|
|
|||
| // // disable body scrolling when the overlay is open | |||
|
The image on the home page is not 1-1 with dev right now on Chrome - is that expected? It looks a bit larger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the image width discrepancy seen on the dev site between Chrome and Safari. After some discussions with @ludtkemorgan, it seems that it is coming from the browsers' handling of css specificity since the image card properties are running into the listings-row css properties and handling them differently. Switching these two properties addressed the issue, and when we bring the updated image back to Core, we should further investigate the source of this issue.
Chrome:
Safari: