-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cherry-picked forgot-password from core #1566
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -307,7 +307,6 @@ | |||
"authentication.createAccount.reEnterEmail": "Vuelva a introducir la dirección de correo electrónico", | |||
"authentication.createAccount.reEnterPassword": "Reingresa tu contraseña", | |||
"authentication.createAccount.resendTheEmail": "Volver a enviar el email", | |||
"authentication.forgotPassword.success": "Te hemos enviado un correo electrónico. Recibirás un correo electrónico con un enlace para restablecer tu contraseña.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to get the translated strings for the new message? I believe it is also not translated in core as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I was referring to in standup @sarahlazarich!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I think we can do this in google translate -- I'll put the translations in the original ticket!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚽
* fix: cherry-picked commit from core * fix: update testing approach to mirror core * fix: undo core test mirroring * fix: resolve testing error * fix: revert unrelated changes * fix: space cleanup * fix: space cleanup pt 2 * fix: translations added
* fix: reset focus for NVDA (#1556) * fix: first attempt to reset focus for nvda * fix: attemmpt with asPath approach * fix: reset focus in application file * fix: missing tabIndex value * fix: hidden new page approach * fix: new page with state * fix: functional navigation announcement * fix: cleaned up css approach * fix: remove unused css * fix: remove space typo * fix: nvda testing without alert * fix: re-instate alert * fix: simpler solution for cross browser support * fix: remove alert since focused * fix: announcement clean up * fix: variable naming * fix: announcement updates pr LH feedback * fix: heading level typo * fix: clean up string handling * fix: clean up rebase * feat: change labels for no min/max rent (#1569) * fix: release ux issues (#1571) * refactor: uptake uic siteheader (#1565) * fix: show all listings button labels (#1568) * feat: add meaningful labels to filter buttons * feat: change reset button label * fix: add missing filter translations for spanish * fix: cherry-picked forgot-password from core (#1566) * fix: cherry-picked commit from core * fix: update testing approach to mirror core * fix: undo core test mirroring * fix: resolve testing error * fix: revert unrelated changes * fix: space cleanup * fix: space cleanup pt 2 * fix: translations added * fix: custom focus management (#1572) * fix: custom focus management * fix: clean up + commenting * fix: remove auto fix from linter * fix: add missing screen reader only labels to fields (#1573) * fix: update to community type draggability (#1578) * fix: description grid misalignment (#1581) * fix: description grid misalignment * fix: description misalignment --------- Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com> Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com>
Pull Request Template
Issue Overview
This PR addresses #1546
Description
This PR is a cherry-pick from Core (with a few adjustments) so that entering an email on the forgot password page will return a neutral message that doesn't indicate if the email exists or not. This PR also adds tests to verify the backend changes required.
How Can This Be Tested/Reviewed?
This can be tested by submitting an email that exists in the db on the forgot password page and then one that doesn't to ensure that the UX is the same. This should be tested on both the partner's and public side.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.