fix: listings export clean up #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for detroit-storybook-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
emilyjablonski
approved these changes
Mar 17, 2023
ColinBuyck
changed the title
ludtkemorgan
pushed a commit
that referenced
this pull request
Mar 21, 2023
* fix: local import * fix: unit tests fix
Merged
ludtkemorgan
added a commit
that referenced
this pull request
Mar 28, 2023
* feat: add user csv export (#1560) * feat: listing export (#1548) * feat: starting listing export * fix: wip building listing query * fix: csv support * fix: adding column definitions wip * fix: wip address query * fix: updates to fix query * fix: wip listing selects * fix: reformatted testing output * fix: completed select statements * fix: exporter service wip * fix: a11y features formatting * fix: wip adding to exporter * fix: wip lottery info formatting * fix: wip date formatting * fix: listings exporter service fields (95%) * fix: complete units csv building * fix: functioning zip download * fix: req.user type casting * fix: refactor to config approach * fix: various csv bugs * fix: debugging column values * fix: user access array * fix: clean up * fix: clean up pt 2 * fix: ui content and error handling * fix: ui content and error handling actually * fix: cleanup + cypress test * fix: cypress test and naming clean up * fix: unit test draft * fix: error handling fix * fix: removed unused seed * fix: functional cypress and wip unit tests * fix: one functional unit test * fix: functional unit tests * fix: wip error test * fix: error message test * fix: wip module mocking * fix: generateAsnyc readded to test * fix: controller cleanup * fix: functional success message testing * fix: testing cleanup * fix: further testing and comment cleanup * fix: toast timeout * fix: clean up formatting * fix: column cleanup * fix: console log cleanup * fix: rebase cleanup * fix: wip bug fixes * fix: wip data bug resolutions * fix: unit bug fixes * fix: formatting contd * fix: clean up * fix: button focus issue * fix: testing repository error * fix: include csv exporter service in test * fix: refined testing fix * fix: button color correction * fix: align sizing and export language --------- Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> * fix: listings export clean up (#1590) * fix: local import * fix: unit tests fix * fix: add aria label to min/max rent fields (#1582) * fix: remove the due date question (#1584) * 1525/user access issue (#1592) * fix: include admin who are not partners * fix: correct user seed * fix: remove admin from permissions column * fix: testing cleanup * fix: change test location * fix: add undefined check * fix: add aria label to table (#1585) * fix: add aria label to table * fix: add aria labels to detail tables * fix: unit labeling on detailed page * fix: add aria-label to grouped table * fix: add descriptive alt tags to listings images (#1587) * fix: add descriptive alt tags to listings images * fix: add empty value to alt text * fix: remove redundant photo string * fix: remove redundant image string from translations * fix: change min/max rent inputs from number to text with only numbers (#1599) * fix: resolve bugs from bash (#1597) * fix: resolve bugs from bash * fix: paper app helper * fix: refine helper * fix: user export fixes (#1600) * fix: user export fixes * fix: fix tests * fix: add cypress downloads to gitignore file * fix: release scrub (#1604) * fix: align csv error messages * fix: timezone temporary approach * fix: align application export * fix: formatting case consistency * fix: missing UTC * feat: focus title on modal open (#1558) * feat: focus title on modal open * feat: bring back id to h1 in modal header * fix: add a11y statement (#1601) * fix: added english a11y statement * fix: formatting feedback * fix: spanish added * fix: add ar and bn * fix: remove unused div and styling --------- Co-authored-by: ColinBuyck <53269332+ColinBuyck@users.noreply.github.com> Co-authored-by: Yazeed Loonat <yazeedloonat@gmail.com> Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com> Co-authored-by: Emily Jablonski <65367387+emilyjablonski@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #1525
Description
Manually deploying the backend after merging in listings export resulted in the following error.
I believe it is caused by attempting to import backend/core which was not included in its package.json file. Additionally, pretty sure that importing a package that the file itself belongs to would create a circular dependency. The fix above should address that.
Also, realize the unit tests need to be updated to reflect the change to Export to CSV language so that is handled here as well.
How Can This Be Tested/Reviewed?
Not sure here.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.