Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flip min rent with max rent #1634

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix: flip min rent with max rent #1634

merged 1 commit into from
Aug 16, 2023

Conversation

KrissDrawing
Copy link
Collaborator

Pull Request Template

Issue Overview

This PR addresses #1633

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

It changes comparator signs so it matches field

How Can This Be Tested/Reviewed?

Go to listings, set min/max rent filters. Now it should properly show filtered listings.
Also check for finder

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for detroit-public-dev ready!

Name Link
🔨 Latest commit a9e12b1
🔍 Latest deploy log https://app.netlify.com/sites/detroit-public-dev/deploys/64d5ef9c9c2fa20008b386ba
😎 Deploy Preview https://deploy-preview-1634--detroit-public-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023 •
edited
Loading

✅ Deploy Preview for detroit-partners-dev ready!

Name Link
🔨 Latest commit a9e12b1
🔍 Latest deploy log https://app.netlify.com/sites/detroit-partners-dev/deploys/64d5ef9cb191e80008b2c447
😎 Deploy Preview https://deploy-preview-1634--detroit-partners-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski
emilyjablonski approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻‍❄️

ColinBuyck
ColinBuyck approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧋 (Detroit requires two reviews to merge)

@ludtkemorgan ludtkemorgan merged commit f590d31 into dev Aug 16, 2023
14 checks passed
@ludtkemorgan ludtkemorgan deleted the 1633/Filtering-by-Min-Max-seems-to-be-flipped branch August 16, 2023 14:12
ludtkemorgan pushed a commit that referenced this pull request Aug 16, 2023
@KrissDrawing @ludtkemorgan
fix: flip min rent with max rent (#1634)
761b31f
@ludtkemorgan ludtkemorgan mentioned this pull request Aug 16, 2023
Merged
ludtkemorgan added a commit that referenced this pull request Aug 21, 2023
@ludtkemorgan @KrissDrawing
Release: 2023-08-16 (#1636)
a5de9b2 
* fix: flip min rent with max rent (#1634)

* fix: format currency before filter form submit (#1635)

---------

Co-authored-by: Krzysztof Zięcina <kriss.kontakt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinBuyck ColinBuyck ColinBuyck approved these changes

@emilyjablonski emilyjablonski emilyjablonski approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KrissDrawing @ColinBuyck @emilyjablonski @ludtkemorgan