-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format currency before filter form submit #1635
fix: format currency before filter form submit #1635
Conversation
✅ Deploy Preview for detroit-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for detroit-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥼
Pull Request Template
Issue Overview
This PR addresses #1632
Description
We were sending formatted currency string, so with commas. This PR removes them before form submitting.
min and max filter fields are switched (so min act as max, and max as min) -> it's solved in different PR
How Can This Be Tested/Reviewed?
Go to listings page, and filter by min / max rent, type number bigger that 1000. Check if it filters correctly. Same for finder.
You can verify if it passes "number string" without commas to query url params, and if it sends it in this format to backend.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.