Update addFilter to take a map of filter type to field name #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update addFilter to take a map of filter type to field name
Addresses #202
Description
entity
param inaddFilter()
with a map from filter name to field name, so we can filter on things that are in joined tables.WHERE
clauses for filters of the same typeType of change
How Can This Be Tested/Reviewed?
Test with paths like
/listings?filter[$comparison]=<>&filter[nEIGhborhood]=Foster%20cIty
(1 result)http://localhost:3100/listings?filter[$comparison]==&filter[name]=Test:%20Triton&filter[$comparison]=<>&filter[neighborhood]=Coliseum
(1 result)/listings?filter[$comparison]=<>&filter[neighborhood]=Coliseum&filter[$comparison]==&filter[neighborhood]=Foster%20City
(1 result)Checklist: