Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing bedrooms error #388

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

avaleske
Copy link

@avaleske avaleske commented Aug 11, 2021

Pull Request Template

Issue

Addresses #324

  • This change addresses only certain aspects of the issue

Description

Forgot to update a file in #368

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Build the backend

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@avaleske avaleske linked an issue Aug 11, 2021 that may be closed by this pull request
3 tasks
@avaleske avaleske requested a review from willrlin August 11, 2021 20:51
@avaleske avaleske merged commit a8f7ce7 into main Aug 11, 2021
@avaleske avaleske deleted the avaleske/fix-missing-bedrooms-error branch August 11, 2021 21:07
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Size Filter
2 participants