This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Add prompt.py tests for create wallet #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit 'daf700d9c365a64d619148b3c029eb827863a260': Feature events (#91)
- updated docstrings to <param name> (<type>): <description> (and added a bunch of period's to be consistent in all docstrings)
…into development * 'development' of https://github.com/CityOfZion/neo-python: Fix 797966 (#93) increase verion to 0.4.0 doc fix, leveldb-blockchain log info->debug for trimming headers
…into development * 'development' of https://github.com/CityOfZion/neo-python: Typo: when disabling sc-events in prompt, now says "disabled" requirements.txt update neo-python-rpc to 0.1.8 (fixes #96) fix for #95, fix for #94 Fixed contrib/claim* scripts by removing SubscribeNotifications
…into development * 'development' of https://github.com/CityOfZion/neo-python: setup.py + refactorings (contrib.smartcontract -> neo.contrib.smartcontract) (#97) Documentation updates: Settings, logging, smart contract interaction (#98)
* development: stay off my edits Merge >:|!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address?, or what feature is it adding?
prompt.pyof Cleanup in create wallet flow (error handling,add docstrings, deadcode) #92How did you solve this problem?
update
.coveragercto include the root dir, otherwiseprompt.pywould not be included.How did you make sure your solution works?
ran the test case
Did you add any tests?
yes
Did you check your
pycodestyle?yes
Are there any special changes in the code that we should be aware of?
no
Are you making a PR to a feature branch or development rather than master?
development