Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Fix for invoke script parameter passing #15

Closed
wants to merge 2 commits into from
Closed

Fix for invoke script parameter passing #15

wants to merge 2 commits into from

Conversation

hal0x2328
Copy link
Member

Made changes to the stack packing operations to replicate neo-gui invoke script output

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.857% when pulling 99f5eea on hal0x2328:master into d59e64c on CityOfZion:master.

@hal0x2328 hal0x2328 closed this Oct 1, 2017
@hal0x2328
Copy link
Member Author

Just found EmitPushBigInteger, will refactor and resubmit

Copy link
Collaborator

@localhuman localhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every SC accepts params, so this would throw an error for any SC which doesn't.

@localhuman
Copy link
Collaborator

I think there could be different solution to your problem.

Could you send me a script hash you're trying to invoke, and the params you're trying to invoke with? That way I can test :)

@localhuman localhuman reopened this Oct 1, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.857% when pulling 99f5eea on hal0x2328:master into d59e64c on CityOfZion:master.

@localhuman
Copy link
Collaborator

Alright, I'm looking at the ICO_Template right now, and it looks like the 2nd param is a variable length array/object of more params, in which case your solution makes sense.

However, this approach would break invokes for any invoke that doesn't have variable length params objects.

I can work on a fix for the Invoke method which will accept that type of argument set...

@hal0x2328 hal0x2328 closed this Oct 2, 2017
ixje pushed a commit that referenced this pull request Sep 30, 2018
Merge CoZ Development into jseagrave21 Development
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants