This repository has been archived by the owner on Nov 15, 2021. It is now read-only.
Invoke from address selection #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 16, 2018 11:34
* Added support for --from-addr= for testinvoke and other build/load/invoke commands. * Added `help` documentation for prompt for a couple of missing commands and tab completions.
* Found bug in testing where I wasn't properly translating the from_addr address string into the proper 20-byte (UInt160) script hash. There were only 3 places this was necessary. It keeps the interface to using these methods clean in that a human-readable address can be passed in and will automatically be converted to the script hash.
* Added support for --from-addr= for testinvoke and other build/load/invoke commands. * Added `help` documentation for prompt for a couple of missing commands and tab completions.
…neo-python into invoke-from-address-selection
added 2 commits
March 16, 2018 14:40
brianlenz
commented
Mar 16, 2018
neo/bin/prompt.py
Outdated
| @@ -104,7 +104,7 @@ class PromptInterface(object): | |||
| 'wallet tkn_approve {token symbol} {address_from} {address to} {amount}', | |||
| 'wallet tkn_allowance {token symbol} {address_from} {address to}', | |||
| 'wallet tkn_mint {token symbol} {mint_to_addr} (--attach-neo={amount}, --attach-gas={amount})', | |||
| 'wallet tkn_register {addr} ({addr}...)', | |||
| 'wallet tkn_register {addr} ({addr}...) (--from-addr={addr})', | |||
There was a problem hiding this comment.
I do wonder if we even want to support tkn_register as a native command at all. It's not part of NEP-5, and there are conversations around changing the de facto standard (e.g. camel case instead of underscores). It's easy enough to do with testinvoke, so we may just want to get rid of support for it entirely?
There was a problem hiding this comment.
I think its good to keep around. We're working on an NEP for sale related ICO methods, so once that is complete we can change the syntax to camelCase or whatever it ends up being.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
#322
How did you solve this problem?
Added support for
--from-addr=parameters for the various invoke methods in bothprompt.pyand other relevant commands.How did you make sure your solution works?
Tested it. Updated a test to use it.
Are there any special changes in the code that we should be aware of?
No.
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)