Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Invoke from address selection #329

Merged
merged 6 commits into from Mar 17, 2018
Merged

Invoke from address selection #329

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef0d060
from_addr support for testinvoke
Mar 16, 2018
ba077e4
Fix from_addr translation to script hash
Mar 16, 2018
7673b7e
from_addr support for testinvoke
Mar 16, 2018
0bdff27
Merge branch 'invoke-from-address-selection' of github.com:brianlenz/…
Mar 16, 2018
3e9ca99
Add CHANGELOG
Mar 16, 2018
ecd1c6c
Updated help docs
Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions neo/bin/prompt.py
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@ class PromptInterface(object):
'wallet tkn_approve {token symbol} {address_from} {address to} {amount}',
'wallet tkn_allowance {token symbol} {address_from} {address to}',
'wallet tkn_mint {token symbol} {mint_to_addr} (--attach-neo={amount}, --attach-gas={amount})',
'wallet tkn_register {addr} ({addr}...)',
'wallet tkn_register {addr} ({addr}...) (--from-addr={addr})',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we even want to support tkn_register as a native command at all. It's not part of NEP-5, and there are conversations around changing the de facto standard (e.g. camel case instead of underscores). It's easy enough to do with testinvoke, so we may just want to get rid of support for it entirely?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its good to keep around. We're working on an NEP for sale related ICO methods, so once that is complete we can change the syntax to camelCase or whatever it ends up being.

'wallet unspent',
'wallet close',
'withdraw_request {asset_name} {contract_hash} {to_addr} {amount}',
Expand All @@ -116,7 +116,7 @@ class PromptInterface(object):
'withdraw all # withdraw all holds available',
'send {assetId or name} {address} {amount} (--from-addr={addr})',
'sign {transaction in JSON format}',
'testinvoke {contract hash} {params} (--attach-neo={amount}, --attach-gas={amount})',
'testinvoke {contract hash} {params} (--attach-neo={amount}, --attach-gas={amount}) (--from-addr={addr})',
'debugstorage {on/off/reset}'
]

Expand Down