Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add gettransactionheight RPC method #813

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Add gettransactionheight RPC method #813

merged 3 commits into from
Jan 14, 2019

Conversation

ixje
Copy link
Member

@ixje ixje commented Jan 13, 2019

What current issue(s) does this address, or what feature is it adding?
add neo-project/neo#541

How did you solve this problem?
add code

How did you make sure your solution works?
write tests

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

Copy link
Contributor

@jseagrave21 jseagrave21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Nice to see the tests.

@jseagrave21
Copy link
Contributor

I could PR documentation for this method to neo-project. I have had a couple of correction PRs merged in the past. What do you think @ixje?

@ixje
Copy link
Member Author

ixje commented Jan 14, 2019

Sure why not

@ixje ixje merged commit 07053c7 into CityOfZion:development Jan 14, 2019
@ixje ixje deleted the rpc_-gettransactionheight branch January 14, 2019 09:34
jseagrave21 pushed a commit to jseagrave21/neo-python that referenced this pull request Jan 25, 2019
* Add undocumented gettransactionheight RPC method

* add changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants