first steps to sync

src/NeoSharp.Core/Blockchain/Processing/BlockHeaderPersister.cs

@@ -52,6 +52,7 @@ public async Task Persist(params BlockHeader[] blockHeaders)
 
             foreach (var blockHeader in blockHeadersToPersist)
             {
+                blockHeader.Type = HeaderType.Header;
                 if (blockHeader.Hash == null)
                 {
                     _blockHeaderSigner.Sign(blockHeader);
@@ -94,7 +95,7 @@ private bool Validate(BlockHeader blockHeader)
                 }
             }
 
-            return blockHeader.Type == HeaderType.Extended;
+            return blockHeader.Type == HeaderType.Header;
         }
     }
 }

src/NeoSharp.Core/Blockchain/Processing/BlockPersister.cs

@@ -72,17 +72,19 @@ public async Task Persist(params BlockHeader[] blockHeaders)
 
         public async Task<bool> IsBlockPersisted(Block block)
         {
-            this._logger.LogDebug($"Verify if the {block.Hash} is already in the blockchain.");
+            this._logger.LogDebug($"Verify if the block {block.Hash} is already in the blockchain.");
             var blockHeader = await this._blockRepository.GetBlockHeader(block.Hash);
 
             if (blockHeader?.Type == HeaderType.Extended)
             {
-                throw new InvalidOperationException($"The block \"{block.Hash.ToString(true)}\" exists already on the blockchain.");
+                this._logger.LogDebug($"The block \"{block.Hash.ToString(true)}\" exists already on the blockchain.");
+                return true;
             }
 
             if (blockHeader != null && blockHeader.Hash != block.Hash)
             {
-                throw new InvalidOperationException($"The block \"{block.Hash.ToString(true)}\" has an invalid hash.");
+                this._logger.LogDebug($"The block \"{block.Hash.ToString(true)}\" has an invalid hash.");       // <-- [AboimPinto] I'm not sure if this validation should be on this method.
+                return true;
             }
 
             this._logger.LogDebug($"The block with the hash {block.Hash} is not int the blockchain.");

src/NeoSharp.Core/Blockchain/Processing/BlockProcessor.cs

@@ -54,11 +54,11 @@ public void Run(Block currentBlock)
                 {
                     if (this._blockchainContext.IsPeerConnected && this._blockchainContext.NeedPeerSync && !this._blockchainContext.IsSyncing)
                     {
-                        this._broadcaster.Broadcast(new GetBlocksMessage(this._blockchainContext.CurrentBlock.Hash));
+                        this._broadcaster.Broadcast(new GetBlocksMessage(this._blockchainContext.CurrentBlock?.Hash));
                         this._blockchainContext.IsSyncing = true;
                     }
 
-                    var nextBlockHeight = currentBlock?.Index + 1 ?? 0;
+                    var nextBlockHeight = this._blockchainContext.CurrentBlock?.Index + 1 ?? 0;
 
                     if (!_blockPool.TryGet(nextBlockHeight, out var block))
                     {

src/NeoSharp.Core/Messaging/Handlers/BlockMessageHandler.cs

@@ -56,9 +56,10 @@ public override async Task Handle(BlockMessage message, IPeer sender)
                 this._blockOperationsManager.Sign(block);
             }
 
-            if (this._blockOperationsManager.Verify(block))
+            if (!this._blockOperationsManager.Verify(block))
             {
-                await _blockProcessor.AddBlock(block);
+                this._logger.LogInformation($"Block {block.Hash} verification failed and will not be added.");
+                return;
             }
 
             this._logger.LogInformation($"Adding block {block.Hash} to the BlockPool with Index {block.Index}.");

src/NeoSharp.Core/Models/OperationManger/WitnessOperationsManager.cs

@@ -24,7 +24,8 @@ public void Sign(Witness witness)
 
         public bool Verify(Witness witness)
         {
-            throw new System.NotImplementedException();
+            // TODO [AboimPinto]: need to be implemented.
+            return true;
         }
         #endregion
     }

test/NeoSharp.Core.Test/Blockchain/Processing/UtBlockProcessor.cs

@@ -10,6 +10,7 @@
 using NeoSharp.Core.Helpers;
 using NeoSharp.Core.Models;
 using NeoSharp.Core.Models.OperationManger;
+using NeoSharp.Core.Network;
 using NeoSharp.Core.Persistence;
 using NeoSharp.Core.Types;
 using NeoSharp.TestHelpers;
@@ -201,6 +202,11 @@ public void Run_WhenAddBlockThisIsProcessed_OnBlockProcessedEventRaised()
 
             var blockPersisterMock = this.AutoMockContainer.GetMock<IBlockPersister>();
 
+            this.AutoMockContainer
+                .GetMock<IBlockchainContext>()
+                .SetupGet(x => x.CurrentBlock)
+                .Returns(currentBlock);
+
             var testee = this.AutoMockContainer.Create<BlockProcessor>();
 
             testee.OnBlockProcessed += (_, block) =>