This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
first steps to sync #456
Merged
first steps to sync #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface but it's not anymore, threfore should not carry the prefix "I" that identify the interfaces.
…into development
…into development
…into development
Black listed peers try to connect test
…ge of the method RandomInt. * Small clean up on the UtCrypto
more tests will be added soon!
…into development
…into development
…into development
…into development
…into development
…into development
…into development
…into development
…into development
* Fix an inverted if logic. The code only enter in the While loop if the cancellation was requested and should be the other way around.
merge with development
Increase buffer size (CityOfZion#431)
merge with development
…into development
…tsBuilder and clean up the comment and not used method in Blockchain class. All BlockModel variables were renamed to BlockRepository
…into development
…into development
…/await pattern and all the BlockHeader now have the type = header.
Codecov Report
@@ Coverage Diff @@
## development #456 +/- ##
==============================================
Coverage ? 54.03%
==============================================
Files ? 298
Lines ? 12354
Branches ? 0
==============================================
Hits ? 6676
Misses ? 5678
Partials ? 0
Continue to review full report at Codecov.
|
shargon
reviewed
Oct 1, 2018
| @@ -52,6 +52,7 @@ public async Task Persist(params BlockHeader[] blockHeaders) | |||
|
|
|||
| foreach (var blockHeader in blockHeadersToPersist) | |||
| { | |||
| blockHeader.Type = HeaderType.Header; | |||
There was a problem hiding this comment.
remove from my PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some exception throw because they are getting swallow by async/await pattern and all the BlockHeader now have the type = header.