Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding NFT to Token List #2342

Closed
picarodias opened this issue Dec 15, 2021 · 0 comments
Closed

Adding NFT to Token List #2342

picarodias opened this issue Dec 15, 2021 · 0 comments
Assignees
@comountainclimber
Labels
enhancement

Comments

@picarodias
Copy link

picarodias commented Dec 15, 2021 •
edited

What is to be done?

  • Implement NFTs tab to Wallet home screen
    • Changes to the current Tokens Panel.

Designs

Requirements

Tokens Window

  • Title: Token Balances
  • Dropdown:
    • Assets
    • NFTs
    • (changing the dropdown will toggle the block between Assets Tab and NFTs Tab)

Assets Tab

Shall stay as is currently implemented.

NFTs Tab:

  • Column Headers:

    • Symbol
    • Collection
    • Amount

  • For each collection, render a line:

    • Collection Symbol
      • fetch data from dora
    • Collection name
      • fetch data from dora
    • User Balance (the sum of all NFTs held of that collection)
      • fetch data from contract invocation

  • link: View on GhostMarket

  • icon: GhostMarket Green Icon

Tech resources:
comountainclimber added a commit that referenced this issue Jan 10, 2022
@comountainclimber
Covers issue #2342
ed6f0c7
@comountainclimber comountainclimber mentioned this issue Jan 10, 2022
Merged
comountainclimber added a commit that referenced this issue Jan 12, 2022
@comountainclimber
feature: adds NFT support (#2361)
7ca73ec 
* Covers issue #2342

* Lint and remove test code

* Remove comments

* Use dora to grab manifest data

* Fix margin in GM link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@comountainclimber comountainclimber

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@comountainclimber @picarodias