chore: fixes issues related to pending transactions UX #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
This issue was brought up in the CoZ slack channel
What problem does this PR solve?
How did you solve this problem?
Because we were parsing the vout array to form the pending transactions getting added to the activity page occasionally this was not always creating the most desirable format see this transaction for instance https://neoscan.io/transaction/716e6606f17b3e2453bf9dd9037c1fdafe8bf527afb4cf37c9a29d45e14c9562 => now we simply reference the sendEntries array which resolves the issue
How did you make sure your solution works?
Manual testing
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?