Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: yarn dev issues on Linux #1832

Merged
merged 2 commits into from
Apr 12, 2019
Merged

chore: yarn dev issues on Linux #1832

merged 2 commits into from
Apr 12, 2019

Conversation

uvmetal
Copy link

@uvmetal uvmetal commented Apr 9, 2019

What current issue(s) from Trello/Github does this address?
When executing 'yarn dev' no indication of progress was showing before. Now the build status is output as it goes.

This PR also addresses an issue with Linux (experienced personally on Ubuntu 18.04) where 'yarn dev' builds but Neon never opens. A note was made on the readme.

What problem does this PR solve?
The PR resolves the issue of no clear feedback to the developer of build progress.

This PR also addresses an issue with Linux (experienced personally on Ubuntu 18.04) where 'yarn dev' builds but Neon never opens. A note was made on the readme.

How did you solve this problem?
I added the flag --progress to the package.json build script named 'dev'.

How did you make sure your solution works?
I tested it and verified it showed progress.

Are there any special changes in the code that we should be aware of?
No.

Is there anything else we should know?
No.

  • Unit tests written?
    No.

@coveralls
Copy link

coveralls commented Apr 9, 2019

Pull Request Test Coverage Report for Build 6005

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.709%

Totals Coverage Status
Change from base Build 5985: 0.0%
Covered Lines: 1084
Relevant Lines: 2484

💛 - Coveralls

@uvmetal uvmetal changed the title feature: add --progress to dev script in package.json chore: yarn dev issues Apr 10, 2019
@uvmetal uvmetal changed the title chore: yarn dev issues chore: yarn dev issues on Linux Apr 10, 2019
@comountainclimber comountainclimber merged commit 735eec7 into CityOfZion:dev Apr 12, 2019
@comountainclimber comountainclimber added this to Pending Distribution in Awards Distribution May 10, 2019
@comountainclimber
Copy link
Member

Please award @phetter 100 points

@lllwvlvwlll lllwvlvwlll moved this from Pending Distribution to In Progress in Awards Distribution May 30, 2019
@lllwvlvwlll lllwvlvwlll moved this from In Progress to Distributed in Awards Distribution May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants