feature: activity export enhancements #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6013
💛 - Coveralls |
comountainclimber
added a commit
that referenced
this pull request
Apr 18, 2019
* adds csv dep * removes buggy success notification from activity panel and adds export button in header * sets up working boilerplate for CSV download * updates snapshots * fixes notification weirdness in activity page and adds export functionality * updates snapshots * adds dismiss functionality to info notification * refactor of TransactionHistory.jsx * Updated TOLL to BRDG token with new supply * chore: fixes contacts layout (#1810) * fixes broken layout bug in contacts panel * removes unnused styles * adds working implementation of error boundary around app * removes hardcoded error * styles error page * removes hard coded errors * refactors validation in ContactForm.jsx * reimplements dynamic token hash fetch * bumps version in package.json * feature: activity export enhancements (#1836) * adds disable state to tx history component fixes default file name and location * fixes linting errors * removes commented out import * fixes css bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes two things:
1.) adds disabled state to the new export button in the activity tab so that users cant mash this (or automate the mashing)
2.) Updates the default path of the exported csv to
<path to documents>/neon-wallet-activity-${moment().unix()}.csvVerified manually that file export is still working exactly as expected