Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: handles integer return type for SWTH contract + reduces network requests for balance info #2048

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

comountainclimber
Copy link
Member

What current issue(s) from Trello/Github does this address?

What problem does this PR solve?

How did you solve this problem?

How did you make sure your solution works?

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?

@coveralls
Copy link

coveralls commented Jan 12, 2021

Pull Request Test Coverage Report for Build 7692

  • 8 of 33 (24.24%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 41.581%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/actions/balancesActions.js 8 33 24.24%
Files with Coverage Reduction New Missed Lines %
app/core/nep5.js 5 27.78%
Totals Coverage Status
Change from base Build 7681: -0.1%
Covered Lines: 1501
Relevant Lines: 3276

💛 - Coveralls

@comountainclimber comountainclimber merged commit 3fa13db into dev Jan 13, 2021
@comountainclimber comountainclimber deleted the feature/handle-integer-return-type branch January 13, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants