Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adds backup pricing API #2097

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented Mar 8, 2021

This PR makes it so that our internal API gets queried in the event that cryptocompare is down or client is rate limited....

Essentially just updates getPrices()to accept a conditional in which it will make the request to the alternate url in the event of the prices object being empty.

@coveralls
Copy link

coveralls commented Mar 8, 2021

Pull Request Test Coverage Report for Build 7757

  • 1 of 7 (14.29%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 41.615%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/actions/pricesActions.js 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
app/actions/pricesActions.js 3 6.33%
Totals Coverage Status
Change from base Build 7752: -0.1%
Covered Lines: 1523
Relevant Lines: 3309

💛 - Coveralls

@comountainclimber comountainclimber merged commit 5a9d619 into dev Mar 8, 2021
@comountainclimber comountainclimber deleted the feature/add-backup-price-api branch August 10, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants