Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: n3 support #2127

Closed
wants to merge 47 commits into from
Closed

feature: n3 support #2127

wants to merge 47 commits into from

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented May 6, 2021 •
edited

No description provided.

@coveralls
Copy link

coveralls commented May 6, 2021 •
edited

Pull Request Test Coverage Report for Build 7930

  • 46 of 367 (12.53%) changed or added relevant lines in 24 files are covered.
  • 14 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-2.7%) to 38.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/containers/LoginPrivateKey/LoginPrivateKey.jsx 1 2 50.0%
app/containers/LoginPrivateKey/index.js 2 3 66.67%
app/core/explorer.js 6 7 85.71%
app/hocs/helpers/didLogin.js 0 1 0.0%
app/hocs/helpers/didLogout.js 0 1 0.0%
app/components/Blockchain/Address/Address.jsx 0 2 0.0%
app/components/Blockchain/Transaction/Transaction.jsx 0 2 0.0%
app/core/formatters.js 1 3 33.33%
app/actions/settingsActions.js 0 4 0.0%
app/actions/transactionHistoryActions.js 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
app/actions/contactsActions.js 1 11.35%
app/actions/nodeStorageActions.js 1 66.67%
app/actions/settingsActions.js 1 15.15%
app/containers/Send/Send.jsx 1 49.21%
app/core/formatters.js 1 52.78%
app/core/nep5.js 1 15.38%
app/modules/generateWallet.js 1 41.92%
app/util/findAndReturnTokenInfo.js 1 4.26%
app/components/Send/PriorityFee/PriorityFee.jsx 6 6.67%
Totals Coverage Status
Change from base Build 7811: -2.7%
Covered Lines: 1548
Relevant Lines: 3606
💛 - Coveralls

@comountainclimber comountainclimber changed the title feature: n3 authentication feature: n3 support Jun 22, 2021
comountainclimber
comountainclimber commented Jun 28, 2021
View reviewed changes
app/modules/transactions.js
- Ledger support
- Support for test AND main net
- Node url should come from settings
*/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these should be broken into their own issues ☝️

endkeyCoder and others added 14 commits June 29, 2021 12:53
@endkeyCoder
correction in contacts screen to know when it is neo 3 or neoLegacy #…
57959e8 
…2138 #2137
@endkeyCoder
some corrections in contacts feature
0197353
@endkeyCoder
Fixed bug to show only contacts from n3 when configured for this and …
b6f123c 
…from n2 in the same way
@endkeyCoder
check if chains is array before make a query
8f126ad
@endkeyCoder
type errors fix
3215f6a
@Thacryba
[Contacts] Implement improvements to Dora activity link available for…
103b7b4 
… list items, so it directs the user to the appropriate link, as per Neo Version related to that record #2139
@comountainclimber
feature: support for activity screen (#2142)
8a0dfcb 
* Loading activity with defects

* fix layout issues

* Remove hardcoded GAS in activity tab

* add n3 linking for to dora

* Fix test

* Wire up pending transaction flow

* Wires up pending tx flow fixes type errors

* Fix possible balance bug
@comountainclimber
Fixes reset check (#2143)
35d54c1
@comountainclimber
Feature/n3 tx refactor ii (#2144)
61cd1ee 
* Remove fee buttons if chain is n3

* Fix test
@comountainclimber
feature: additional nep17 support (#2146)
c26201d 
* Remove fee buttons if chain is n3

* Fix test

* Adds support for any nep11

* lint

* Fixes pending tx actions
@comountainclimber
Bump neon-js version
43ee912
@comountainclimber
add broadcasting notification
64f1871
@comountainclimber
Bump version in pack
1edbb9b
@comountainclimber
Update snaps
c07e93b
comountainclimber and others added 20 commits July 6, 2021 12:37
@comountainclimber
Fix electron crashing bug
4cd4de0
@comountainclimber
Fix local storage bug
67d4f76
@comountainclimber
bump version in pack
be1597c
@comountainclimber
Update snapshots
7683984
@comountainclimber @endkeyCoder
feature: support for activity screen (#2142)
72c424d 
* Loading activity with defects

* fix layout issues

* Remove hardcoded GAS in activity tab

* add n3 linking for to dora

* Fix test

* Wire up pending transaction flow

* Wires up pending tx flow fixes type errors

* Fix possible balance bug
@comountainclimber @endkeyCoder
Fixes reset check (#2143)
d3bbfaf
@comountainclimber @endkeyCoder
Feature/n3 tx refactor ii (#2144)
7814a64 
* Remove fee buttons if chain is n3

* Fix test
@comountainclimber @endkeyCoder
feature: additional nep17 support (#2146)
8d414c8 
* Remove fee buttons if chain is n3

* Fix test

* Adds support for any nep11

* lint

* Fixes pending tx actions
@comountainclimber @endkeyCoder
Bump neon-js version
931b805
@comountainclimber @endkeyCoder
add broadcasting notification
afc2f0f
@comountainclimber @endkeyCoder
Bump version in pack
90df8a7
@comountainclimber @endkeyCoder
Update snaps
b8b5b34
@comountainclimber @endkeyCoder
Fix electron crashing bug
782babb
@comountainclimber @endkeyCoder
Fix local storage bug
779606a
@comountainclimber @endkeyCoder
bump version in pack
f6a35a6
@comountainclimber @endkeyCoder
Update snapshots
718f729
@endkeyCoder
it changed the filter of contacts by chain to action contactActions
ff6bde5
@Thacryba
Merge branch 'neon-3-II' of github.com:simplitech/neon-wallet into ne…
9e696b3 
…on-3-II
@melanke
Merge pull request #2140 from simplitech/neon-3-II
09ff8be 
correction in contacts screen to know when it is neo 3 or neoLegacy
@comountainclimber
feature: fix broken build (#2152)
002f5ac 
* Lint

* Fix type errors

* Fix tests
@comountainclimber comountainclimber deleted the neon-3-II branch August 10, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@comountainclimber @coveralls @endkeyCoder @Thacryba @melanke