Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: ledger N3 migration support #2239

Merged
merged 8 commits into from
Sep 8, 2021
Merged

feature: ledger N3 migration support #2239

merged 8 commits into from
Sep 8, 2021

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented Sep 8, 2021 •
edited

@coveralls
Copy link

coveralls commented Sep 8, 2021 •
edited

Pull Request Test Coverage Report for Build 8236

  • 2 of 39 (5.13%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.1%) to 36.1%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/actions/ledgerActions.js 0 1 0.0%
app/containers/LoginLedgerNanoS/index.js 0 1 0.0%
app/components/Modals/LedgerMigrationConfirm/LedgerMigrationConfirm.jsx 1 9 11.11%
app/containers/Send/Send.jsx 0 11 0.0%
app/containers/LoginLedgerNanoS/LoginLedgerNanoS.jsx 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
app/containers/Send/Send.jsx 2 40.49%
app/modules/transactions.js 2 7.39%
Totals Coverage Status
Change from base Build 8212: -1.1%
Covered Lines: 1620
Relevant Lines: 3990
💛 - Coveralls

@comountainclimber comountainclimber merged commit 0aef9dd into feat/2219 Sep 8, 2021
comountainclimber added a commit that referenced this pull request Sep 8, 2021
@lllwvlvwlll @ixje @comountainclimber
ledger state machine enhancements (#2227)
a9be899 
* ledger state machine enhancements

* ledger app lockout

* performance and UI improvements from blocking processes

* linting

* linting

* Fix Windows deploy

* typing

* resolves 'get additional keys' issue

* code formatting

* update docker image

* feature: ledger N3 migration support (#2239)

* Working implementation for ledger migration

* lint

* lint

* update copy

* lint

* Fix type errors

* Adds connect component to confirm modal

Co-authored-by: lllwvlvwlll <lllwvlvwlll@gmail.com>

Co-authored-by: lllwvlvwlll <lllwvlvwlll@gmail.com>
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
Co-authored-by: Maxwell Lasky <mlasky46@gmail.com>
@comountainclimber comountainclimber deleted the feature/ledger-migration branch August 10, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@comountainclimber @coveralls