Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor modules to async await #321

Merged
merged 5 commits into from
Nov 12, 2017

Conversation

dvdschwrtz-zz
Copy link
Collaborator

@dvdschwrtz-zz dvdschwrtz-zz commented Nov 11, 2017

What current issue(s) from Trello/Github does this address?

uses the async helper to make the promises code in the modules files look more like Go code

For example:
const {err, response] = await asyncWrap(promiseFn())
if (err) reponse to err

--
note that due to an issue with react hot loader babel plugin, I left the containers with normal promises, although there are not very many of them.

What problem does this PR solve?

How did you solve this problem?

How did you make sure your solution works?

Are there any special changes in the code that we should be aware of?

Is there anything else we should know?

  • Unit tests written?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.756% when pulling 2cd6e4b on dvdschwrtz:async-wrapper into 52f8e04 on CityOfZion:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.756% when pulling 7e782c3 on dvdschwrtz:async-wrapper into 52f8e04 on CityOfZion:dev.

@evgenyboxer evgenyboxer self-requested a review November 11, 2017 03:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.756% when pulling ae6c511 on dvdschwrtz:async-wrapper into 52f8e04 on CityOfZion:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.756% when pulling 861041c on dvdschwrtz:async-wrapper into 52f8e04 on CityOfZion:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 46.756% when pulling 861041c on dvdschwrtz:async-wrapper into 52f8e04 on CityOfZion:dev.

@evgenyboxer evgenyboxer merged commit 2c7c83f into CityOfZion:dev Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants