refactor send asset function code #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenyboxer
reviewed
Dec 8, 2017
app/modules/transactions.js
Outdated
| @@ -67,25 +67,19 @@ export const sendTransaction = (sendAddress: string, sendAmount: string, symbol: | |||
|
|
|||
| const isHardwareSend = !!publicKey | |||
There was a problem hiding this comment.
Is there a better check for this?
There was a problem hiding this comment.
Maybe we can define the type of the login? Feels like this condition is only known to us..
There was a problem hiding this comment.
yeah, that makes sense. I will incorporate those changes for the ledger login page as well
evgenyboxer
approved these changes
Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
What problem does this PR solve?
How did you solve this problem?
How did you make sure your solution works?
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?