-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added address book management for sending assets #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f76b399
to
9bcb447
Compare
mhuggins
commented
Dec 16, 2017
position: relative; | ||
|
||
.anchor { | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ I can remove this.
Closed
9bcb447
to
6d1cc5c
Compare
6d1cc5c
to
250b970
Compare
dvdschwrtz-zz
approved these changes
Dec 17, 2017
🎉 Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
Finishes #9.
What problem does this PR solve?
It allows users to save & name addresses that they commonly send assets to. There are simple mechanisms for saving (only valid addresses) with custom unique names, as well as deleting addresses that are no longer needed.
How did you solve this problem?
I modified the existing "Send" modal to extend the behavior of the recipient address text input. It is now composed of a more complex set of react components that represent a select input w/ drop-down of existing values (if any values have been added yet).
When the user focuses on the input, it expands the drop-down to show existing values. As the user starts typing, the values are filtered (by both address & name) to match the user's search term.
When a new address has been typed into the address input, a "save" icon is displayed so that the user can save it. If that is clicked, an interactive tooltip allows the user to enter a name for the address before saving.
When a user wishes to delete an address book entry, they can click the trash can icon that appears next to each entry in the drop-down.
How did you make sure your solution works?
I smoke tested it manually, but I did not write any automated tests for it yet.
Are there any special changes in the code that we should be aware of?
Is there anything else we should know?