Added DeepBrain Coin #448
Merged
Added DeepBrain Coin #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure doesn't appear to relate to my change. |
|
Just fyi: I had the same issue with the build. Here was my fix: bfe2090 |
|
@slipo Thanks, rebasing against |
|
Using a ledger I cannot send dbc with this version, error message says not supported |
|
@ministoat I don't have a ledger to test against. I will have to see if someone else can help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
It supports sending & showing balance for DBC (DeepBrain Coin), similar to RPX.
How did you solve this problem?
I added the MainNet & TestNet constants for the DBC hash.
How did you make sure your solution works?
I loaded the wallet and confirmed that I can view the 0 DBC balance & view DBC token information by clicking on the balance. NOTE: I was unable to test transferring DBC due to having a 0 balance.
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
See NOTE above.