Replace parseFloat calls with BigNumber #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
changed the title
dvdschwrtz-zz
approved these changes
Jan 16, 2018
dvdschwrtz-zz
pushed a commit
that referenced
this pull request
Jan 18, 2018
* Fixed transaction history verbosity (#513) * Add RHT token (Redeemable HashPuppy Token) (#499) * Add custom tokens (#539) * Adds token management * Add .settings to ignore * Remove * Remove <div> * Fix e2e * FIX: application gets in bad state if incorrect json filed is used when restoring wallet (#533) * FIX: application gets in bad state if incorrect json filed is used in recovery method * EDIT restore walletHasKey to original format * Replace parseFloat calls with BigNumber (#544) * Removed parseFloat from transaction validation functions * Removed parseFloat from token sale functions * Token sale UI (#546) * setup structure for token sale and fix merge conflicts * working on finishing ICO portion * still working on changes to mint tokens * working on token sale - successfully minting * update token sale code * work in progress. restructured inside dashboard * adding ledger support * ledger and non-ledger minting on the non verified smart contracts * Remove symbol * implement tokens sales ui & lots of other fixes * rework notifications * Fix zero balance bug * Fix nep5 sending * Fixing test * fix tests * remove condtional * update to 0.1.0 * update to 010 (#550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
N/A
What problem does this PR solve?
It replaces several remaining
parseFloatcalls to ensure we use BigNumber instead.How did you solve this problem?
I reused our existing
toBigNumberandtoNumbercalls.How did you make sure your solution works?
I ran the test suite and sent transactions. I did not test the sale changes since this is dependent on #528.
Are there any special changes in the code that we should be aware of?
N/A
Is there anything else we should know?
N/A