-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to neonwallet.com #584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuggins
approved these changes
Jan 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for taking a look @mhuggins |
mhuggins
pushed a commit
to neoverse/neon-wallet
that referenced
this pull request
Jan 30, 2018
* updated neonwallet.com * update to neonwallet.com * updates to download links and social links * updates to neonwallet.com
mhuggins
added a commit
that referenced
this pull request
Jan 30, 2018
updates to neonwallet.com (#584)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
#540
This PR also includes a request https://api.github.com/repos/CityOfZion/neon-wallet/releases/latest which will no longer make it necessary to update download links every time we release.
What problem does this PR solve?
How did you solve this problem?
When the application loads it defaults to
config.js
but after making http request overrides with latest release information.How did you make sure your solution works?
Compiled build tested and new request functions to https://api.github.com/repos/CityOfZion/neon-wallet/releases/latest tested extensively.
Are there any special changes in the code that we should be aware of?
This now contains a minified build which will be a better UX for the average viewer of the page (theres also no need to update download links every release)
Is there anything else we should know?
All of the latest can be found here https://github.com/comountainclimber/neon-website