Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to neonwallet.com #584

Merged
merged 8 commits into from
Jan 21, 2018
Merged

Conversation

comountainclimber
Copy link
Member

@comountainclimber comountainclimber commented Jan 20, 2018

What current issue(s) from Trello/Github does this address?
#540

This PR also includes a request https://api.github.com/repos/CityOfZion/neon-wallet/releases/latest which will no longer make it necessary to update download links every time we release.

What problem does this PR solve?

How did you solve this problem?
When the application loads it defaults to config.js but after making http request overrides with latest release information.

How did you make sure your solution works?
Compiled build tested and new request functions to https://api.github.com/repos/CityOfZion/neon-wallet/releases/latest tested extensively.

Are there any special changes in the code that we should be aware of?
This now contains a minified build which will be a better UX for the average viewer of the page (theres also no need to update download links every release)

Is there anything else we should know?
All of the latest can be found here https://github.com/comountainclimber/neon-website

  • Unit tests written?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 35.015% when pulling 72f5254 on comountainclimber:dev into b674457 on CityOfZion:dev.

Copy link
Contributor

@mhuggins mhuggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@comountainclimber
Copy link
Member Author

Thanks for taking a look @mhuggins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.677% when pulling f429612 on comountainclimber:dev into b674457 on CityOfZion:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.677% when pulling 05a071b on comountainclimber:dev into b674457 on CityOfZion:dev.

@evgenyboxer evgenyboxer merged commit dd43fb3 into CityOfZion:dev Jan 21, 2018
mhuggins pushed a commit to neoverse/neon-wallet that referenced this pull request Jan 30, 2018
* updated neonwallet.com

* update to neonwallet.com

* updates to download links and social links

* updates to neonwallet.com
mhuggins added a commit that referenced this pull request Jan 30, 2018
updates to neonwallet.com (#584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants