Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Intermediate containers #481

Merged
merged 6 commits into from
May 1, 2024
Merged

Conversation

AngrySoundTech
Copy link
Contributor

This PR removes the intermediate step of building our own containers, instead using the base container and templating in our plugins with Ansible. This does cause the deploy to be marginally slower, but in the short term cuts some fat out of our release process and gets us moving again.

@AngrySoundTech AngrySoundTech marked this pull request as ready for review April 30, 2024 22:25
Copy link
Contributor

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 9e09bec
Logs https://github.com/CivMC/Civ/actions/runs/8902431008
Download https://github.com/CivMC/Civ/suites/23319197091/artifacts/

Copy link
Contributor

@okx-code okx-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm happy for you or sorry that happened

@AngrySoundTech AngrySoundTech merged commit 314a693 into main May 1, 2024
4 checks passed
@AngrySoundTech AngrySoundTech deleted the feature/eliminate-containers branch May 1, 2024 15:51
@AngrySoundTech AngrySoundTech self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants