overlay: Exit rcS script so it only runs once #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever wondered why the /proc/version output appears in the logs twice? I discovered that if we exit from the scripts instead of doing nothing, it only appears once! I could speculate what's going on but I don't precisely know. Signed-off-by: Joel Stanley <joel@jms.id.au>
shenki
requested review from
msfjarvis,
nathanchance,
nickdesaulniers and
tpimh
as code owners
|
I don't have a cbl setup at the moment to fully test., but I did test locally in my buildroot environment. |
|
Actually, it looks like this is because This should fix it: diff --git a/buildroot/overlay-poweroff/etc/init.d/S50yolo b/buildroot/overlay-poweroff/etc/init.d/S50yolo
index 2b06371..0499d71 100755
--- a/buildroot/overlay-poweroff/etc/init.d/S50yolo
+++ b/buildroot/overlay-poweroff/etc/init.d/S50yolo
@@ -1,4 +1,6 @@
#!/bin/sh
-cat /proc/version
-poweroff
+if [ "$1" = "start" ]; then
+ cat /proc/version
+ poweroff
+fi
diff --git a/buildroot/overlay-reboot/etc/init.d/S50yolo b/buildroot/overlay-reboot/etc/init.d/S50yolo
index ed0203b..0bc3e46 100755
--- a/buildroot/overlay-reboot/etc/init.d/S50yolo
+++ b/buildroot/overlay-reboot/etc/init.d/S50yolo
@@ -1,4 +1,6 @@
#!/bin/sh
-cat /proc/version
-reboot
+if [ "$1" = "start" ]; then
+ cat /proc/version
+ reboot
+fi |
|
Even better! Feel free to push your change instead of mine |
nathanchance
added a commit
to nathanchance/boot-utils
that referenced
this pull request
Apr 7, 2021
Currently, when booting the images, the version string prints out twice. This is because these scripts are called twice: once with the "start" action and again with the "stop" action. To avoid this, just run the contents of the script when the service is starting. Closes: ClangBuiltLinux#41 Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever wondered why the /proc/version output appears in the logs twice?
I discovered that if we exit from the scripts instead of doing nothing,
it only appears once! I could speculate what's going on but I don't
precisely know.
Signed-off-by: Joel Stanley joel@jms.id.au