This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
debian-setup: Install libelf-dev #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That fail is fixed in #47 (because the out of tree patch that removes that failure message didn't get applied) but this is probably worth adding, I'll defer to Nick for further comment. |
nathanchance
suggested changes
Nov 12, 2018
nathanchance
added a commit
to ClangBuiltLinux/dockerimage
that referenced
this pull request
Nov 12, 2018
ClangBuiltLinux/continuous-integration#48 ClangBuiltLinux/continuous-integration#49 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
|
Alright, this pull is good and is needed (verified with commit + Travis build, which I will push after this is merged) but the build will not pass until #47 is merged. |
nathanchance
approved these changes
Nov 12, 2018
The job failure at [1] appears to have been due to the libelf-dev package being missing. It is available in the sid repositories [2] so we can install it directly. [1]: https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/157821684#L576 [2]: https://packages.debian.org/sid/libelf-dev
nathanchance
added a commit
to nathanchance/continuous-integration
that referenced
this pull request
Nov 12, 2018
I had this in my personal patchset because according to ClangBuiltLinux/linux#14, the CONFIG_ORC_UNWINDER check was causing the build to error. I never actually verified that result myself. Along with ClangBuiltLinux#48 and this patch, there are no warnings/errors and we should now see all objtool warnings: https://travis-ci.com/nathanchance/continuous-integration/builds/91060888 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
nathanchance
added a commit
to nathanchance/continuous-integration
that referenced
this pull request
Nov 12, 2018
I had this in my personal patchset because according to ClangBuiltLinux/linux#14, the CONFIG_ORC_UNWINDER check was causing the build to error. I never actually verified that result myself. Along with ClangBuiltLinux#48 and this patch, there are no warnings/errors[1]. The biggest reason for removing the changes to this file are to avoid potential merge conflicts[2]. [1]: https://travis-ci.com/nathanchance/continuous-integration/builds/91060888 [2]: https://lore.kernel.org/lkml/1539681053-24388-3-git-send-email-yamada.masahiro@socionext.com/ Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
|
thanks @MSF-Jarvis !!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job failure at 1 appears to have been due to the libelf-dev package being missing. It is available in the sid repositories 2 so we can install it directly.