This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
patches: x86_64: Remove Makefile change #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had this in my personal patchset because according to ClangBuiltLinux/linux#14, the CONFIG_ORC_UNWINDER check was causing the build to error. I never actually verified that result myself. Along with ClangBuiltLinux#48 and this patch, there are no warnings/errors[1]. The biggest reason for removing the changes to this file are to avoid potential merge conflicts[2]. [1]: https://travis-ci.com/nathanchance/continuous-integration/builds/91060888 [2]: https://lore.kernel.org/lkml/1539681053-24388-3-git-send-email-yamada.masahiro@socionext.com/ Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this in my personal patchset because according to ClangBuiltLinux/linux#14,
the CONFIG_ORC_UNWINDER check was causing the build to error. I never
actually verified that result myself. Along with #48 and this patch,
there are no warnings/errors1. The biggest reason for removing the
changes to this file are to avoid potential merge conflicts2.