I386 #33
Merged
I386 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc #17 Still need to add check_logs.py support once ClangBuiltLinux/linux#1210 is fixed.
|
Does continuous-integration2/utils.py Line 58 in 2d66107 Or should we just update boot-utils to take i386 instead of x86? |
Likely, see comment:
(I don't expect this to close issue #17; it's just the first half. I'd prefer to fix up utils.py once the build actually produces a binary image remotely that I can test with) |
nathanchance
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i386 support
cc #17
Still need to add check_logs.py support once
ClangBuiltLinux/linux#1210 is fixed.