Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wmisleading-indentation in drivers/video/fbdev/core/fbcon.c #824

Closed
nathanchance opened this issue Dec 18, 2019 · 1 comment
Closed

-Wmisleading-indentation in drivers/video/fbdev/core/fbcon.c #824

nathanchance opened this issue Dec 18, 2019 · 1 comment
Assignees
@nathanchance
Labels
-Wmisleading-indentation [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM

Comments

@nathanchance
Copy link
Member 

../drivers/video/fbdev/core/fbcon.c:915:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
        return err;
        ^
../drivers/video/fbdev/core/fbcon.c:912:2: note: previous statement is here
        if (!search_fb_in_map(info_idx))
        ^
1 warning generated.

Patch submitted: https://lore.kernel.org/lkml/20191218025337.35044-1-natechancellor@gmail.com/
@nathanchance nathanchance added [BUG] linux A bug that should be fixed in the mainline kernel. [PATCH] Submitted A patch has been submitted for review -Wmisleading-indentation labels Dec 18, 2019
@nathanchance nathanchance self-assigned this Dec 18, 2019
@nathanchance
Copy link
Member Author

No longer relevant after llvm/llvm-project@b4b904e.

@nathanchance nathanchance added [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM and removed [BUG] linux A bug that should be fixed in the mainline kernel. [PATCH] Submitted A patch has been submitted for review labels Jan 5, 2020
ruscur pushed a commit to ruscur/linux that referenced this issue Jan 16, 2020
@nathanchance @bzolnier
fbcon: Adjust indentation in set_con2fb_map
2be2450 
Clang warns:

../drivers/video/fbdev/core/fbcon.c:915:3: warning: misleading
indentation; statement is not part of the previous 'if'
[-Wmisleading-indentation]
        return err;
        ^
../drivers/video/fbdev/core/fbcon.c:912:2: note: previous statement is
here
        if (!search_fb_in_map(info_idx))
        ^
1 warning generated.

This warning occurs because there is a space before the tab on this
line. This happens on several lines in this function; normalize them
so that the indentation is consistent with the Linux kernel coding
style and clang no longer warns.

This warning was introduced before the beginning of git history so no
fixes tab.

Link: ClangBuiltLinux#824
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191218025337.35044-1-natechancellor@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanchance nathanchance

Labels
-Wmisleading-indentation [BUG] llvm (main) A bug in an unreleased version of LLVM (this label is appropriate for regressions) [FIXED][LLVM] main This bug was only present and fixed in an unreleased version of LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathanchance