Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc-PR, tc-RK, and others #189

Merged
merged 52 commits into from
Sep 14, 2023
Merged

tc-PR, tc-RK, and others #189

merged 52 commits into from
Sep 14, 2023

Conversation

longemen3000
Copy link
Member

closes #126 , addresses #188

@longemen3000
Copy link
Member Author

nightly errors are unrelated

longemen3000 added a commit that referenced this pull request Jul 26, 2023
@longemen3000
backport changes from #189
05fe8d4
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #189 (488376d) into master (1805269) will decrease coverage by 0.58%.
The diff coverage is 56.98%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   83.16%   82.58%   -0.58%     
==========================================
  Files         251      258       +7     
  Lines       16150    16456     +306     
==========================================
+ Hits        13431    13591     +160     
- Misses       2719     2865     +146
Files Changed Coverage Δ
ext/ClapeyronCoolPropExt.jl 11.76% <0.00%> (-88.24%) ⬇️
src/Clapeyron.jl 100.00% <ø> (ø)
src/models/EmpiricHelmholtz/SingleFluid/parser.jl 77.19% <ø> (ø)
src/models/cubic/PR/variants/PR78.jl 100.00% <ø> (ø)
src/models/cubic/PR/variants/UMRPR.jl 100.00% <ø> (ø)
src/models/cubic/PR/variants/VTPR.jl 100.00% <ø> (ø)
src/models/cubic/RK/variants/tcRK.jl 0.00% <0.00%> (ø)
src/models/cubic/alphas/BM.jl 95.65% <ø> (ø)
src/models/cubic/alphas/MT.jl 50.00% <ø> (ø)
src/models/cubic/alphas/alphas.jl 94.73% <ø> (ø)
... and 29 more

@longemen3000
remove some missings in tcPR
e23e34f
@longemen3000
Merge branch 'master' of https://github.com/ClapeyronThermo/Clapeyron.jl
bdd36a7 
 into tc-pr-actres
@longemen3000
typo in cPR
7f931cb
@longemen3000
typos found during standarization
028bb5f
@longemen3000
typos found in normalization (2)
2e7b29a
@longemen3000
typos found in normalization (3)
74fc5e7
@longemen3000
typos found in normalization
be9dad1
@longemen3000
default_locations for activities
5d54641
@longemen3000
update identifiers (last time i swear)
4f0c436
@longemen3000
prenormalize some dbs
f80bd2d
@longemen3000
restore cpr to original state, update identifiers
835c334
@longemen3000
use formatted_components in cPR
5e15d46
@longemen3000
rackett compressibility factor DB
7521050
@longemen3000
use master db for tcPR
2190f0c
@longemen3000
normalize names across all databases
50e61eb
@longemen3000
restore PTFlashWrapper old behaviour for CompositeModel
6c3dceb
@longemen3000
define tcPRW
43cebca
@longemen3000
remove repeated entry in critical.csv
5dd1325
@longemen3000
typos found in test
21a48e5
@longemen3000
typo found in test (v_shift in L/mol), add tcPRW test
4a4a3e7
@longemen3000
add news
efc8bc8
@longemen3000
add "heptyl acetate" to identifiers, normalize group databases
16a50b5
@longemen3000
typo in hydrogen, cis-1,3-Dimethylcyclohexane, add all missing compou…
d39930e 
…nds to critical.csv
@longemen3000
add components to molarmass.csv
852ec4b
@longemen3000
weird character in molarmass.csv
488376d
@longemen3000 longemen3000 merged commit 7912654 into master Sep 14, 2023
20 of 22 checks passed
@longemen3000 longemen3000 deleted the tc-pr-actres branch September 26, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pw0908 pw0908 pw0908 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tcPR, tcRK and families
2 participants
@longemen3000 @pw0908