Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAGLE-3454] [EAGLE-3447] - Organize model types and Fix text output dim #171

Merged
merged 8 commits into from
Sep 15, 2023

Conversation

phatvo9
Copy link
Contributor

@phatvo9 phatvo9 commented Sep 11, 2023

Why

model types and their config are called in many files but not put in any constant variables
TextOutput receives 1-d array that causes error in media process

How

put configs in yaml files
Fix by reducing to 0

@phatvo9 phatvo9 changed the title Draft [EAGLE-3454] - Organize model types [EAGLE-3454] [EAGLE-3447] - Organize model types and Fix text input dim Sep 13, 2023
@phatvo9 phatvo9 marked this pull request as ready for review September 13, 2023 11:57
@phatvo9 phatvo9 changed the title [EAGLE-3454] [EAGLE-3447] - Organize model types and Fix text input dim [EAGLE-3454] [EAGLE-3447] - Organize model types and Fix text output dim Sep 13, 2023
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget to address Harmit's unresolved comments above.

@phatvo9 phatvo9 merged commit 1c4b670 into master Sep 15, 2023
4 checks passed
@phatvo9 phatvo9 deleted the EAGLE-3454 branch September 15, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants