Add checksums API #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has different behavior than the WP checksums API for versions that aren't found: https://api.wordpress.org/core/checksums/1.0/?version=4.9.99&locale=en_US returns |
|
This seems to work exactly as required. I've carried out extensive testing on an upgrade from APIs used for testingCP 1.1.4: https://api-v1-test.classicpress.net/checksums/1.1.4.json ResultThe upgrade copied 275 files in total as shown here (arranged in alphabetical order for convenience): Show filesTo cross-check this, I used the command Error checkingTo test what happens when an invalid API URL is used, I set the "new" API to https://api-v1-test.classicpress.net/checksums/4.9.15.json. Although this returned a 404, the upgrade continued but copied all files instead of just the ones that had changed. |
|
Thank you for checking @timbocode. It sounds like this is doing what it's supposed to do, but I am still not clear on the exact conditions required for a file not to be copied/upgraded as it should be. Does this happen on any upgrade from v1.1.4 to v1.2.0, or is an earlier version also required to be installed before v1.1.4? I am also thinking it would be a good idea to add another path component here for the type of checksum being used. This would mean that https://api-v1-test.classicpress.net/checksums/1.1.4.json becomes https://api-v1-test.classicpress.net/checksums/md5/1.1.4.json, and we'd have a natural place to put checksums using other hash algorithms in the future. |
5 tasks
|
Also, a minor improvement that shouldn't block us getting the initial version out, but the |
nylen
force-pushed
the
add/checksums-api
branch
from
3a07c67
to
26ef196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks to work properly from my quick testing. Closes #16.