Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Themes: use aria-current for the Walker_Nav_Menu current link (and patch) #1022

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Accessibility: Themes: use aria-current for the Walker_Nav_Menu current link (and patch) #1022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6cd6d
WP-r42808: Accessibility: Themes: use `aria-current` for the `Walker_…
afercia Aug 25, 2022
65f8f53
Fix WPCS indentation
bahiirwa Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/wp-includes/class-walker-nav-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,12 @@ public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0

$output .= $indent . '<li' . $id . $class_names . '>';

$atts = array();
$atts['title'] = ! empty( $item->attr_title ) ? $item->attr_title : '';
$atts['target'] = ! empty( $item->target ) ? $item->target : '';
$atts['rel'] = ! empty( $item->xfn ) ? $item->xfn : '';
$atts['href'] = ! empty( $item->url ) ? $item->url : '';
$atts = array();
$atts['title'] = ! empty( $item->attr_title ) ? $item->attr_title : '';
$atts['target'] = ! empty( $item->target ) ? $item->target : '';
$atts['rel'] = ! empty( $item->xfn ) ? $item->xfn : '';
$atts['href'] = ! empty( $item->url ) ? $item->url : '';
$atts['aria-current'] = $item->current ? 'page' : '';

/**
* Filters the HTML attributes applied to a menu item's anchor element.
Expand All @@ -188,6 +189,7 @@ public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0
* @type string $target Target attribute.
* @type string $rel The rel attribute.
* @type string $href The href attribute.
* @type string $aria_current The aria-current attribute.
* }
* @param WP_Post $item The current menu item.
* @param stdClass $args An object of wp_nav_menu() arguments.
Expand Down