Replace links from the WordPress News to the ClassicPress Blog #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Dashboard widget, #40
nylen
reviewed
Nov 29, 2018
nylen
reviewed
Nov 29, 2018
nylen
reviewed
Nov 29, 2018
|
Explanation of my comments above: we shouldn't translate our site URLs, since they will be available in English only for the time being. Previously: ClassicPress/ClassicPress-v1#193 Apart from that, this PR looks good as a first step. 👍 |
|
Thanks for reviewing, @nylen! Gettext functions now removed from URLs. |
nylen
approved these changes
Nov 29, 2018
|
Thanks! |
6 tasks
dikiyforester
added a commit
to dikiyforester/ClassicPress
that referenced
this pull request
Dec 9, 2018
* petitions: (21 commits) Travis fix for JSLint Style new ally HTML tab JSLint error fix Use the right ally markup Use the right ally markup jshint fix - Strings must use singlequote Add transient key to save the internet with cache Add transient key to save the internet with cache Fixing tab spacing Fix Spacing & Comment Remove CP Naming Add Dashboard petitions widget Add Petitions Dashboard widget Renovate[bot]: Update dependency autoprefixer to v9.4.0 (ClassicPress#256) Renovate[bot]: Update Node.js to v10.14.1 (ClassicPress#252) Change dashboard news from WordPress News to the ClassicPress Blog (ClassicPress#248) Renovate[bot]: Update Node.js to v10.14.0 (ClassicPress#251) Renovate[bot]: Update dependency webpack to v4.26.1 (ClassicPress#249) Bump source version to 1.0.0-beta1+dev Fix upgrades from ClassicPress to ClassicPress ...
mattyrob
pushed a commit
that referenced
this pull request
Nov 20, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces links from the WordPress News to the ClassicPress Blog in the News widget on the Dashboard.
Changes number of fetching items from 1 to 5.
Motivation and context
This is an early step of implementation ClassicPress/ClassicPress-v1#236. A small change to make news links consistent.
According to comment ClassicPress/ClassicPress-v1#236
How has this been tested?
Needs to clear the transient cache before testing.
Or alternatively, comment out a block of code:
ClassicPress/src/wp-admin/includes/dashboard.php
Lines 985 to 988 in 3d68141
Types of changes
Checklist: