Add classes to H2 tags in user-edit.php #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unique classes to the profile editing page <h2> tags.
Add classes to H2 tags in user-edit.php
nylen
approved these changes
Dec 5, 2019
|
Great thanks! Guess that means I'll have some editing to do here. :) |
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/classicpress-1-2-0-rc1-release-notes/2479/1 |
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/classicpress-1-2-0-release-notes/2516/1 |
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/rearrange-profile-page-so-important-fields-are-at-top/3650/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds classes to the <h2> tags on the profile editing page so they can be more carefully targeted with CSS selectors. Fixes ClassicPress/ClassicPress-v1#137.
Description
Updated several h2 tags with unique classes.
Motivation and context
The current h2 tags lack classes which make them difficult to select with CSS unless they are selected wholesale. This is not ideal when you're only trying to remove a section or two. Using nth-child selectors can work in some cases, but, that method quickly degrades if a plugin or theme adds custom sections and skews the element count.
How has this been tested?
Inspecting the source; visually in a browser.
Types of changes
Checklist: