WP-r48241: Administration: Pass the result of set-screen-option fil…
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter to the new `set_screen_option_{$option}` filter to ensure backward compatibility.
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.
WP:Props Chouby, sswells, SergeyBiryukov.
Fixes https://core.trac.wordpress.org/ticket/50392.
---
Merges https://core.trac.wordpress.org/changeset/48241 / WordPress/wordpress-develop@48f0e74279 to ClassicPress.
nylen
approved these changes
Aug 8, 2020
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/classicpress-1-2-0-rc1-release-notes/2479/1 |
|
This pull request has been mentioned on ClassicPress Forums. There might be relevant details there: https://forums.classicpress.net/t/classicpress-1-2-0-release-notes/2516/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter to the new
set_screen_option_{$option}filter to ensure backward compatibility.Rename the
$keepparameter of both filters to$screen_optionfor clarity, update the documentation to better reflect its purpose.WP:Props Chouby, sswells, SergeyBiryukov.
Fixes https://core.trac.wordpress.org/ticket/50392.
Merges https://core.trac.wordpress.org/changeset/48241 / WordPress/wordpress-develop@48f0e74279 to ClassicPress.
Description
Backport of upstream fix
Motivation and context
Fix for upstream ticket 50392
How has this been tested?
Backported through all supported branched of WP
Types of changes