Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deactivating wc/cc problem #168

Merged
merged 4 commits into from Jan 11, 2020
Merged

Fix deactivating wc/cc problem #168

merged 4 commits into from Jan 11, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 10, 2020

All Submissions:

Changes proposed in this Pull Request:

Fix code in main classic-commerce.php file to allow deactivating of WC before activating of CC. Change message in html-notice-require-compat-plugin.php to add sentence about deleting WooCommerce not deleting your data.

Closes #165 .

How to test the changes in this Pull Request:

  1. Copy the 2 changed files into a test site with both WC and CC installed
  2. Deactivate one and activate the other.
  3. Repeat. Observe message when activating CC.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Changelog entry

Allow deactivating of WC before activating of CC. Add message about deleting WooCommerce not deleting your data.

classic-commerce.php Outdated Show resolved Hide resolved
@timbocode timbocode added this to the 1.0.0-alpha3 milestone Jan 11, 2020
@bahiirwa bahiirwa merged commit 01a764d into ClassicPress:develop Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't activate CC after deactivating WC
3 participants